Update FillPlayerTradeModal.tsx #403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insraq
reviewed
Mar 4, 2025
There was a problem hiding this comment.
Thanks for the PR. However, I have substantial concerns w.r.t the quality of the PR:
- There are lots of opaque mechanisms and magic values in the code, that should be avoided
- There are lots of debug/develop code that should be cleaned before merging
- The implementation is essentially a "workaround" and doesn't address the fundamental problem
- Localization is not provided
- The PR does not pass code quality checks
| @@ -35,6 +35,12 @@ export function FillPlayerTradeModal({ tradeId, xy }: { tradeId: string; xy?: Ti | |||
| const allTradeBuildings = Tick.current.playerTradeBuildings; | |||
| const [fills, setFills] = useState(new Map<Tile, number>()); | |||
|
|
|||
| const DEFAULT_HINTS = "greedy"; | |||
There was a problem hiding this comment.
I am not sure why DEFAULT_HINTS is needed here. Having an opaque variable should generally be avoided
| // major changes 2025-02-xx | ||
| // param "hint" can be "greedy" or "fast" to tweak some limits | ||
| // param "maxError" reserved for future use, to set tolerance for fluctuating, erronous or invalid values | ||
| const calculateMaxFill = (hints = "auto", maxError = 0.03) => { |
There was a problem hiding this comment.
Again, hints should not be included. Also the magic number 0.03 should not be included
| amountLeft -= amount; | ||
|
|
||
| // enable some tweaks only in large trades | ||
| const isLargeTrade = trade.buyAmount >= 10000000; // 10 million |
There was a problem hiding this comment.
10000000 magic number should be avoided
| // todo: localize | ||
| let tradeStr = `${total} / ${fills.size}`; | ||
| let resourceStr = `${formatNumber(fillAmount)} ${trade.buyResource}`; | ||
| let str1 = `Filling trades ${tradeStr}, sending: ${resourceStr}...`; |
There was a problem hiding this comment.
All strings should be localized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.