feat(go): Add ai > document #2253
Conversation
github-actions
bot
added
docs
| # TODO(ssbushi): Replace with generated type | ||
| class EmbeddingModel(BaseModel): | ||
| """Represents an embedding with metadata.""" | ||
|
|
||
| embedding: Embedding | ||
| metadata: dict[str, Any] | None = None | ||
|
|
There was a problem hiding this comment.
This is a placeholder for now, will update with the generated type we should get from tooling.
|
| # Copyright 2025 Google LLC | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| from __future__ import annotations |
| media: None = None | ||
|
|
||
|
|
||
| class TextPart(BaseModel): |
There was a problem hiding this comment.
aren't these defined in typing.py already?
| @@ -0,0 +1,146 @@ | |||
| """Tests for Genkit document.""" | |||
There was a problem hiding this comment.
nit: please run bin/fmt it automatically formats and adds license headers when run in the pre-commits.
| """ | ||
|
|
||
| text: str | ||
| media: None = None |
There was a problem hiding this comment.
You need to add an annotation with Union, something like " | None". Media should probably be of Media or Media1 format from genkit.core.typing.
| metadata: dict[str, Any] | None = None | ||
|
|
||
|
|
||
| class Document(DocumentData): |
There was a problem hiding this comment.
For me it's a bit strange to inherit Pydantic model. Is it possible to use composition over inheritance here?
| type Part = TextPart | MediaPart | ||
|
|
||
|
|
||
| class DocumentData(BaseModel): |
There was a problem hiding this comment.
there's already DocumentData in
| def data_type(self) -> str | None: | ||
| """Gets the content_type of the data that is returned by data().""" | ||
| if self.text(): | ||
| return 'text' |
There was a problem hiding this comment.
As you've used 'text' several times, I suggest you to add it as a constant or a class field.
Fixes: #2129
Checklist (if applicable):