Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(py): Implementation of Embed API in Ollama Plugin #2222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(py): Implementation of Embed API in Ollama Plugin #2222

wants to merge 1 commit into from
+557 −170

Conversation

kirgrim
Copy link
Contributor

@kirgrim kirgrim commented Mar 3, 2025

Description:

  • Implemented Embed API for Ollama Plugin
  • Added sample script for embedder workflow

Checklist (if applicable):

@github-actions github-actions bot added feature New feature or request python Python labels Mar 3, 2025
Irillit
Irillit reviewed Mar 3, 2025
View reviewed changes
@kirgrim kirgrim force-pushed the hrymailo/feat/ollama-embedders-api branch from 12160c4 to 70d110b Compare March 3, 2025 16:01
@kirgrim kirgrim force-pushed the hrymailo/feat/ollama-embedders-api branch 2 times, most recently from 9436857 to d922083 Compare March 5, 2025 16:00
@github-actions github-actions bot added docs Improvements or additions to documentation config labels Mar 5, 2025
@pavelgj
Copy link
Collaborator

pavelgj commented Mar 5, 2025

this PR is fine, but for ollama model plugin could you please go though the checklist and see what else is applicable:
https://discord.com/channels/1255578482214305893/1346128564868616306/1346156158724866189

@kirgrim kirgrim force-pushed the hrymailo/feat/ollama-embedders-api branch from d922083 to 13fa811 Compare March 6, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelgj pavelgj pavelgj approved these changes

@Irillit Irillit Irillit approved these changes

@timere-nemo timere-nemo Awaiting requested review from timere-nemo

Assignees
No one assigned
Labels
config docs Improvements or additions to documentation feature New feature or request python Python
Projects
Genkit Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirgrim @pavelgj @Irillit