feat(py): Python GoogleAi plugin #2173
Conversation
github-actions
bot
added
docs
kamilkorski
force-pushed
the
korski/py-googleai-plugin
branch
from
e9f4018 to
fbdee64
Compare
kamilkorski
requested review from
yesudeep,
pavelgj,
kirgrim and
timere-nemo
There was a problem hiding this comment.
Please also introduce some tests verifying it works structure-wise, you can copy and adapt tests from https://github.com/firebase/genkit/pull/1828/files#diff-285168c0aaeff7b2a46f86c5cfd05113fdd9f050e75d40d9c4c9c2b9a085561eR12
kamilkorski
force-pushed
the
korski/py-googleai-plugin
branch
4 times, most recently
from
212514e to
cd4ba35
Compare
kamilkorski
force-pushed
the
korski/py-googleai-plugin
branch
3 times, most recently
from
4d90976 to
cb598d4
Compare
| def _genkit_to_googleai_cfg( | ||
| self, genkit_cfg: GenerationCommonConfig | ||
| ) -> genai.types.GenerateContentConfig: | ||
| """Translate genkit generation config to Google Ai geberate config |
There was a problem hiding this comment.
Is it generate config? I think, you have a typo.
| ) | ||
|
|
||
| if ctx.is_streaming: | ||
| ctx.send_chunk(chunk=response.text) |
There was a problem hiding this comment.
chunks need to be wrapped in GenerateResponseChunk objects.
| The model's response to the generation request. | ||
| """ | ||
|
|
||
| reqest_msgs: list[genai.types.Content] = [] |
| return GenerateResponse( | ||
| message=Message( | ||
| role=Role.MODEL, | ||
| content=[TextPart(text=response.text)], |
There was a problem hiding this comment.
we want to preserve the multipart structure of the response, so each response part needs to be converted separately. Ex: Gemini can have code execution parts...
| for p in msg.content: | ||
| message_parts.append( | ||
| genai.types.Part.from_text(text=p.root.text) | ||
| ) |
There was a problem hiding this comment.
Need to support multimodal parts as well. Need to test and convert all these part types:
There was a problem hiding this comment.
perhaps call out to a helper converter function, and we can add support for each part type separately.
kamilkorski
force-pushed
the
korski/py-googleai-plugin
branch
2 times, most recently
from
f14804b to
34397e2
Compare
kamilkorski
force-pushed
the
korski/py-googleai-plugin
branch
from
34397e2 to
70d65f9
Compare
Created google ai plugin
Checklist (if applicable):