Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threats reviewed and amended for RDMS #676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

abikhuil
Copy link
Contributor

Made the following amendments

  • Added missing common feature to feature list
  • Amended ID ordering
  • Removed duplicated threats
  • Added new common threats to RDMS

@abikhuil abikhuil requested review from a team as code owners February 24, 2025 17:10
Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for common-cloud-controls canceled.

Name Link
🔨 Latest commit 2b7acea
🔍 Latest deploy log https://app.netlify.com/sites/common-cloud-controls/deploys/67bca81232ce16000824333a

Copy link
Contributor

@smendis-scottlogic smendis-scottlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the features.yaml changes

Copy link
Contributor

@mlysaght2017 mlysaght2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM - thanks @abikhuil. Left a comment for a specific threat.

@abikhuil - are you ok to cover RDMS controls next? Thanks!

- T1040

- id: CCC.RDMS.TH06
- id: CCC.RDMS.TH04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abikhuil @eddie-knight - This threat as its written sounds a little vague in terms of its impact. Would like to get your thoughts on how we can make it a little more clear - e.g. does it relate to Data Encrypted for Impact or is it more about the loss of confidentiality?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're talking about Snapshot Collection with Unauthorized Encryption Key... that whole entry is confusing for me at the moment. I feel like there must be something technical I'm misunderstanding 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zigmax - interested to get your views here and your feedback on the full threat list for RDMS please - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants