Prepare crypto/key for release candidate #672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrabotka
commented
Feb 20, 2025
vrabotka
commented
- Added features for Key Expiry, Regionality, Replication, Usage Limits, Permissions, Export
- Added common threat CCC.TH04 and common control CCC.C10
…, Permissions, Export
✅ Deploy Preview for common-cloud-controls canceled.
|
12 tasks
smendis-scottlogic
requested changes
Feb 24, 2025
| description: | | ||
| Supports the ability to assign distinct permission sets to different entities for each key | ||
| - id: CCC.KeyMgmt.F28 | ||
| title: Key Export |
There was a problem hiding this comment.
Can you check whether this feature is allowed in AWS and GCP please?
| description: | | ||
| Supports the ability to securely replicate a key across different regions | ||
| - id: CCC.KeyMgmt.F26 | ||
| title: Key Usage Limits |
There was a problem hiding this comment.
All 3 service providers have different usage limits for keys. But do they allow it to set by the users? Can you provide some references for this capability from AWS, Azure and GCP docs?
| - id: CCC.KeyMgmt.F25 | ||
| title: Key Replication | ||
| description: | | ||
| Supports the ability to securely replicate a key across different regions |
There was a problem hiding this comment.
Suggested change
| Supports the ability to securely replicate a key across different regions | |
| Supports the ability to securely replicate a key across different regions using automated or manual process. |
| description: | | ||
| Supports the ability to set an expiration date for a key | ||
| - id: CCC.KeyMgmt.F24 | ||
| title: Key Regionality |
There was a problem hiding this comment.
We have a common feature CCC.F22 # Location Lock-In.
Better to have that included under common_features and remove CCC.KeyMgmt.F24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.