Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ovsp4rt functions (draft) #65

Draft
wants to merge 4 commits into
base: ffoulkes
Choose a base branch
from
Draft

Rename ovsp4rt functions (draft) #65

wants to merge 4 commits into from

Conversation

ffoulkes
Copy link
Owner

@ffoulkes ffoulkes commented Mar 2, 2025 •
edited
Loading

Changes

  • Renamed functions that directly encode protobufs from Prepare to Encode.
  • Renamed functions that directly write protobufs from Config to Write.
  • Renamed functions that directly read protobufs from Get to Read.

Issues

This PR breaks the legacy (non-client) build because ovsp4rt.cc uses the old function names, and ovsp4rt_private.h and the unit tests use the new ones. The CI pipeline does a legacy build (as it should).

Conclusions

  • This might be worth doing, in small batches, if applied to both ovsp4rt.cc and newovsp4rt.cc at the same time.
  • This will make it more difficult to upstream/downstream to/from ipdk-io (not that this is likely to happen).

ffoulkes added 4 commits March 1, 2025 20:48
@ffoulkes
Rename functions that directly encode protobufs
bc4fd6f 
- Renamed functions that directly encode protobufs from `Prepare`
  to `Encode`.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>
@ffoulkes
Rename functions that directly write protobufs
bea060d 
- Renamed functions that directly write protobufs from 'Config'
  to 'Write'.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>
@ffoulkes
Rename functions that directly read protobufs
9bcb6dc 
- Renamed functions that directly read protobufs from 'Get'
  to 'Read'.

Signed-off-by: Derek Foster <justffoulkes@gmail.com>
@ffoulkes
Corrected an oversight
f10de5d 
Signed-off-by: Derek Foster <justffoulkes@gmail.com>
@ffoulkes ffoulkes marked this pull request as draft March 2, 2025 14:32
@ffoulkes ffoulkes changed the title Rename ovsp4rt functions Rename ovsp4rt functions (draft) Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ffoulkes