-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows tolerances to be callable #958
base: fenicsx
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fenicsx #958 +/- ##
========================================
Coverage 96.02% 96.03%
========================================
Files 45 45
Lines 2490 2494 +4
========================================
+ Hits 2391 2395 +4
Misses 99 99 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Kaelyn! Just a couple of suggestions to make this better
Proposed changes
Allows tolerances to be callable (not just an integer or float). Solves callable and returns a float before passing tolerance to fenicsx.
Types of changes
What types of changes does your code introduce to FESTIM?
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...