Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows tolerances to be callable #958

Open
wants to merge 19 commits into
base: fenicsx
Choose a base branch
from

Conversation

kaelyndunnell
Copy link
Contributor

@kaelyndunnell kaelyndunnell commented Mar 3, 2025

Proposed changes

Allows tolerances to be callable (not just an integer or float). Solves callable and returns a float before passing tolerance to fenicsx.

Types of changes

What types of changes does your code introduce to FESTIM?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Black formatted
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (01ab7f9) to head (11ef95f).

Additional details and impacted files
@@           Coverage Diff            @@
##           fenicsx     #958   +/-   ##
========================================
  Coverage    96.02%   96.03%           
========================================
  Files           45       45           
  Lines         2490     2494    +4     
========================================
+ Hits          2391     2395    +4     
  Misses          99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RemDelaporteMathurin RemDelaporteMathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Kaelyn! Just a couple of suggestions to make this better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants