Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csharp): Fix bug where a lambda for sending HTTP requests would use the HTTP request from the outer scope instead of the local scope #6280

Merged
merged 2 commits into from
Mar 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fern/pages/changelogs/cli/2025-03-02.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## 0.56.0-rc4
**`(feat):`** If experimental.openapi-parser-v3 is enabled in docs.yml, OpenAPI documents will now be
converted directly to IR, bypassing the intermediate Fern Definition step.
**`(feat):`** If experimental.openapi-parser-v3 is enabled in docs.yml, OpenAPI documents will now be
converted directly to IR, bypassing the intermediate Fern Definition step.

This makes sure that the old code path is completely ignored if the flag is enabled.

Expand Down
4 changes: 2 additions & 2 deletions fern/pages/changelogs/cli/2025-03-03.mdx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## 0.56.0-rc5
**`(fix):`** Fixed duplicate validation messages in docs validation by deduplicating violations
that have the same message, node path, file path, and severity.
**`(fix):`** Fixed duplicate validation messages in docs validation by deduplicating violations
that have the same message, node path, file path, and severity.

This prevents showing the same broken link error multiple times.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ export class HttpEndpointGenerator extends AbstractEndpointGenerator {
writer.writeNodeStatement(
csharp.codeblock((writer) => {
writer.write(
`var ${SEND_REQUEST_LAMBDA_VARIABLE_NAME} = async (HttpRequestMessage request, CancellationToken ${cancellationTokenName}) => {`
`var ${SEND_REQUEST_LAMBDA_VARIABLE_NAME} = async (HttpRequestMessage ${HTTP_REQUEST_VARIABLE_NAME}, CancellationToken ${cancellationTokenName}) => {`
);
writer.indent();
writer.write(`var ${RESPONSE_VARIABLE_NAME} = `);
Expand Down
7 changes: 7 additions & 0 deletions generators/csharp/sdk/versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@
# Set `enable-forward-compatible-enums` to `false` in the configuration to generate the old enums.
# irVersion: 53

- version: 1.12.0-rc6
createdAt: "2025-03-03"
irVersion: 56
changelogEntry:
- type: fix
summary: Fix bug where a lambda for sending HTTP requests would use the HTTP request from the outer scope instead of the local scope.

- version: 1.12.0-rc5
createdAt: "2025-03-03"
irVersion: 56
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading