feat(csharp): Add custom pager #6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…harp/custom-pager
…harp/custom-pager
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
…pi/fern into niels/csharp/custom-pager
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
fern-support
temporarily deployed
to
Fern Dev
GitHub Actions
Inactive
…pi/fern into niels/csharp/custom-pager
amckinney
approved these changes
Mar 1, 2025
Comment on lines
+29
to
+36
| [Obsolete("Use SendRequestAsync instead.")] | ||
| public Task<ApiResponse> MakeRequestAsync( | ||
| BaseApiRequest request, | ||
| CancellationToken cancellationToken = default | ||
| ) | ||
| { | ||
| return SendRequestAsync(request, cancellationToken); | ||
| } |
There was a problem hiding this comment.
The RawClient is internal, so we can also just remove this entirely. We can also do that in a follow-up if you prefer.
There was a problem hiding this comment.
I'm overly cautious here for .fernignore'd files
generators/csharp/sdk/src/endpoint/http/HttpEndpointGenerator.ts
Outdated
Show resolved
Hide resolved
generators/csharp/sdk/src/endpoint/http/HttpEndpointGenerator.ts
Outdated
Show resolved
Hide resolved
… mock tests for custom pagination endpoint
Swimburger
commented
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To do in follow-up PR, reconcile BiPager and Pager, and custom pager endpoints with normal pager endpoints (breaking change).
Changes Made
Testing