-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency katex to v0.16.21 [security] #877
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request updates the katex dependency from version 0.16.11 to 0.16.21. This update addresses multiple security vulnerabilities, including those related to the 'trust' option, the use of '\includegraphics', '\edef', and '\htmlData' commands, which could lead to arbitrary JavaScript execution, denial-of-service, or invalid HTML generation. Sequence diagram showing KaTeX security vulnerability with trust optionsequenceDiagram
actor Attacker
participant KaTeX
participant Output
Note over Attacker, Output: Before fix (v0.16.11)
Attacker->>KaTeX: Input with uppercase protocol (e.g., 'Javascript:')
KaTeX->>KaTeX: trust check (protocol !== 'javascript')
Note right of KaTeX: Check fails to catch uppercase variant
KaTeX->>Output: Malicious JavaScript link rendered
Note over Attacker, Output: After fix (v0.16.21)
Attacker->>KaTeX: Input with uppercase protocol
KaTeX->>KaTeX: normalize protocol case
KaTeX->>KaTeX: trust check
KaTeX->>Output: Blocked malicious content
Flow diagram of KaTeX security improvementsflowchart TD
A[Input LaTeX] --> B{Version Check}
B -->|v0.16.11| C[Vulnerable Processing]
B -->|v0.16.21| D[Secure Processing]
C --> E[Protocol Case Sensitive]
C --> F[Unvalidated htmlData]
C --> G[Unsafe includegraphics]
C --> H[Unbounded edef expansion]
D --> I[Protocol Case Insensitive]
D --> J[Validated htmlData]
D --> K[Safe includegraphics]
D --> L[Bounded edef expansion]
style C fill:#ffcccc
style D fill:#ccffcc
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!
This PR contains the following updates:
0.16.11
->0.16.21
GitHub Vulnerability Alerts
CVE-2024-28246
Impact
Code that uses KaTeX's
trust
option, specifically that provides a function to block-list certain URL protocols, can be fooled by URLs in malicious inputs that use uppercase characters in the protocol. In particular, this can allow for malicious input to generatejavascript:
links in the output, even if thetrust
function tries to forbid this protocol viatrust: (context) => context.protocol !== 'javascript'
.Patches
Upgrade to KaTeX v0.16.10 to remove this vulnerability.
Workarounds
trust
function.context.protocol
viacontext.protocol.toLowerCase()
before attempting to check for certain protocols.trust
option.Details
KaTeX did not normalize the
protocol
entry of thecontext
object provided to a user-specifiedtrust
-function, so it could be a mix of lowercase and/or uppercase letters.It is generally better to allow-list by protocol, in which case this would normally not be an issue. But in some cases, you might want to block-list, and the KaTeX documentation even provides such an example:
Currently KaTeX internally sees
file:
andFile:
URLs as different protocols, socontext.protocol
can befile
orFile
, so the above check does not suffice. A simple workaround would be:Most URL parsers normalize the scheme to lowercase. For example, RFC3986 says:
CVE-2024-28245
Impact
KaTeX users who render untrusted mathematical expressions could encounter malicious input using
\includegraphics
that runs arbitrary JavaScript, or generate invalid HTML.Patches
Upgrade to KaTeX v0.16.10 to remove this vulnerability.
Workarounds
trust
option, or set it to forbid\includegraphics
commands."\\includegraphics"
.Details
\includegraphics
did not properly quote its filename argument, allowing it to generate invalid or malicious HTML that runs scripts.For more information
If you have any questions or comments about this advisory:
CVE-2024-28243
Impact
KaTeX users who render untrusted mathematical expressions could encounter malicious input using
\edef
that causes a near-infinite loop, despite settingmaxExpand
to avoid such loops. This can be used as an availability attack, where e.g. a client rendering another user's KaTeX input will be unable to use the site due to memory overflow, tying up the main thread, or stack overflow.Patches
Upgrade to KaTeX v0.16.10 to remove this vulnerability.
Workarounds
Forbid inputs containing the substring
"\\edef"
before passing them to KaTeX.(There is no easy workaround for the auto-render extension.)
Details
KaTeX supports an option named
maxExpand
which prevents infinitely recursive macros from consuming all available memory and/or triggering a stack overflow error. However, what counted as an "expansion" is a single macro expanding to any number of tokens. The expand-and-define TeX command\edef
can be used to build up an exponential number of tokens using only a linear number of expansions according to this definition, e.g. by repeatedly doubling the previous definition. This has been corrected in KaTeX v0.16.10, where every expanded token in an\edef
counts as an expansion.For more information
If you have any questions or comments about this advisory:
CVE-2025-23207
Impact
KaTeX users who render untrusted mathematical expressions with
renderToString
could encounter malicious input using\htmlData
that runs arbitrary JavaScript, or generate invalid HTML.Patches
Upgrade to KaTeX v0.16.21 to remove this vulnerability.
Workarounds
trust
option, or set it to forbid\htmlData
commands."\\htmlData"
.Details
\htmlData
did not validate its attribute name argument, allowing it to generate invalid or malicious HTML that runs scripts.For more information
If you have any questions or comments about this advisory:
Release Notes
KaTeX/KaTeX (katex)
v0.16.21
Compare Source
Bug Fixes
v0.16.20
Compare Source
Bug Fixes
v0.16.19
Compare Source
Bug Fixes
strict
function type (#4009) (4228b4e)v0.16.18
Compare Source
Bug Fixes
v0.16.17
Compare Source
Bug Fixes
v0.16.16
Compare Source
Features
v0.16.15
Compare Source
Features
\mathsfit
command (#3998) (2218901)v0.16.14
Compare Source
Features
v0.16.13
Compare Source
Bug Fixes
\vdots
and\rule
support in text mode (#3997) (0e08352), closes #3990v0.16.12
Compare Source
Features
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.