build: Add support for find_package(Arrow REQUIRED)
#12599
+12
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
assignUser
reviewed
Mar 11, 2025
assignUser
approved these changes
Mar 11, 2025
kou
force-pushed
the
error-on-system-arrow-not-found
branch
3 times, most recently
from
a26e9f8 to
09b06c0
Compare
kou
commented
Mar 12, 2025
| set(Arrow_FOUND false) | ||
| return() | ||
| endif() | ||
| add_library(thrift ALIAS thrift::thrift) |
There was a problem hiding this comment.
Oh, sorry. I should not have removed this. I'll revert this change.
kou
force-pushed
the
error-on-system-arrow-not-found
branch
from
09b06c0 to
917b3fb
Compare
In this PR, I didn't remove any function. Should I rebase on main? |
|
Yes I think that should fix it |
The current `CMake/FindArrow.cmake` ignores `REQUIRED` argument in `find_package(Arrow REQUIRED)`. If `-DArrow_SOURCE=SYSTEM` is specified but system Arrow isn't found, `FindArrow.cmake` finishes without an error. With this change, `-DArrow_SOURCE=SYSTEM` and no system Arrow reports an error. `find_package_handle_standard_args()` is a standard function provided by CMake to handle `REQUIRED`: https://cmake.org/cmake/help/latest/module/FindPackageHandleStandardArgs.html Our other `FindXXX.cmake`s also use it.
kou
force-pushed
the
error-on-system-arrow-not-found
branch
from
917b3fb to
9dd1dc6
Compare
|
OK. I've rebased. |
assignUser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
CMake/FindArrow.cmakeignoresREQUIREDargument infind_package(Arrow REQUIRED). If-DArrow_SOURCE=SYSTEMisspecified but system Arrow isn't found,
FindArrow.cmakefinisheswithout an error.
With this change,
-DArrow_SOURCE=SYSTEMand no system Arrow reportsan error.
find_package_handle_standard_args()is a standard function providedby CMake to handle
REQUIRED:https://cmake.org/cmake/help/latest/module/FindPackageHandleStandardArgs.html
Our other
FindXXX.cmakes also use it.