refactor: Add macro to refactor array functions registration #12577
+58
−145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
jinchengchenghh
changed the title
jinchengchenghh
force-pushed
the
func
branch
2 times, most recently
from
f5aea4f to
f6d0410
Compare
|
Can you help review this PR? Thanks! @rui-mo @zhli1142015 |
zhli1142015
reviewed
Mar 11, 2025
| registerArrayRemoveFunctions<Varbinary>(prefix); | ||
| registerArrayRemoveFunctions<Generic<T1>>(prefix); | ||
| REGISTER_SCALAR_FUNCTIONS_WITHOUT_VARCHAR( | ||
| registerArrayRemoveFunctions, prefix); | ||
| registerFunction< | ||
| ArrayRemoveFunctionString, |
There was a problem hiding this comment.
Do you know the reason why we need to implement a separate function specifically for the VARCHAR type?
There was a problem hiding this comment.
The StringWriter push_back API uses copy_from which is a deep copy, usually in the simple function case, it should be a reference copy.
There was a problem hiding this comment.
So we use setNoCopy instead of push_back for VARCHAR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.