Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HashProbe load LazyVector before wrapping #12563

Closed
wants to merge 2 commits into from
Closed

fix: HashProbe load LazyVector before wrapping #12563

wants to merge 2 commits into from
+87 −4

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented Mar 6, 2025 •
edited
Loading

Fixes #12484

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 6, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 5072a81
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67c971d373741d000886adfc

@zml1206 zml1206 marked this pull request as draft March 6, 2025 08:29
@zml1206 zml1206 marked this pull request as ready for review March 6, 2025 10:00
Yuhta
Yuhta requested changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@Yuhta Yuhta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will destroy the performance. Your optimizer should remove duplicated projections instead.

@zml1206
Copy link
Contributor Author

zml1206 commented Mar 7, 2025

This will destroy the performance. Your optimizer should remove duplicated projections instead.

Although it does not make sense to duplicate the same fields like select a as b, a as c, this is also allowed by standard SQL. If the user uses this as the final output, we cannot modify it in the optimizer. So should Velox support this scenario?

@Yuhta
Copy link
Contributor

Yuhta commented Mar 7, 2025

@zml1206 No the optimizer should use a project node to duplicate the result again for the user

@zml1206 zml1206 mentioned this pull request Mar 10, 2025
Open
@zml1206
Copy link
Contributor Author

zml1206 commented Mar 10, 2025

Thank you for your answer, I will fix it in gluten @Yuhta

@zml1206 zml1206 closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuhta Yuhta Yuhta requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lazy vector: An unloaded lazy vector cannot be wrapped by two different top level vectors in hash join
3 participants
@zml1206 @Yuhta @facebook-github-bot