build: Remove usage of cub from Block.cuh and related test code #12545
+171
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
dreveman
force-pushed
the
use-breeze
branch
2 times, most recently
from
ad6eb54 to
b84b788
Compare
assignUser
reviewed
Mar 5, 2025
added 9 commits
March 10, 2025 13:05
Allow CUDA_PLATFORM_SPECIALIZATION_HEADER to be specified when running cmake and define a breeze_cuda interface library that targets that use breeze can depend on.
Also update the comment to match the code.
Also switches to using warp-striped arrangement as more efficient for radix sort and required by breeze.
Ran velox/experimental/wave/jit/make_headers.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior is not changing but block radix sort performance is expected to improve as a result of using warp-striped arrangement and avoiding unnecessary conversions.