build(ci): Enable pyvelox macos #12543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
assignUser
force-pushed
the
enable-pyvelox-macos
branch
from
0c49c2f to
5638893
Compare
kgpai
approved these changes
Mar 7, 2025
kgpai
added
the
ready-to-merge
|
@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12524
Homebrew builds libraries with a deployment target matching the platform you are on (13/14 in this case) and delocate check this, so we can not build wheels that work on anything lower than macos 13 for intel and 14 for arm. Unless we build all dependencies we pull from brew from source, which doesn't really seem worth it.
Stacked on #12516