misc: Add ability to remove a function from all registries #12537
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Summary: This addresses an internal use-case where, during initialization, all Presto functions are registered before some are overwritten with custom implementations. Since vector functions are prioritized over simple functions, this approach enables replacing a previously registered vector function with a simple function. To simplify the API and prevent confusion between removing specific signatures versus all, this API is designed to remove all signatures, providing a clean slate for the user. Reviewed By: kgpai Differential Revision: D70594709
|
This pull request was exported from Phabricator. Differential Revision: D70594709 |
bikramSingh91
force-pushed
the
export-D70594709
branch
from
780307e to
f8e045a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D70594709 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
Mar 5, 2025
…ncubator#12537) Summary: This addresses an internal use-case where, during initialization, all Presto functions are registered before some are overwritten with custom implementations. Since vector functions are prioritized over simple functions, this approach enables replacing a previously registered vector function with a simple function. To simplify the API and prevent confusion between removing specific signatures versus all, this API is designed to remove all signatures, providing a clean slate for the user. Reviewed By: kgpai Differential Revision: D70594709
|
Linux build failed due to unrelated test failing, filed a bug report for it: #12546 |
kgpai
approved these changes
Mar 7, 2025
|
This pull request has been merged in 598b9d3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This addresses an internal use-case where, during initialization,
all Presto functions are registered before some are overwritten
with custom implementations. Since vector functions are prioritized
over simple functions, this approach enables replacing a previously
registered vector function with a simple function. To simplify the
API and prevent confusion between removing specific signatures versus
all, this API is designed to remove all signatures, providing a clean
slate for the user.
Reviewed By: kgpai
Differential Revision: D70594709