fix: GCC13 build failures

[xin-zhang2]

Fix #12497 .

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	9addb45
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/67cefebda1543f0008437e1b

[majetideepak]

Why add {} here?

[xin-zhang2]

Initialize options explicitly to avoid using it uninitialized.

/root/velox/./velox/dwio/dwrf/common/Compression.h:99:10: error: ‘options’ is used uninitialized [-Werror=uninitialized]
   99 |   return options;
      |          ^~~~~~~
/root/velox/./velox/dwio/dwrf/common/Compression.h: In member function ‘virtual void TestSeek_uncompressed_Test::TestBody()’:
/root/velox/./velox/dwio/dwrf/common/Compression.h:90:22: note: ‘options’ declared here
   90 |   CompressionOptions options;
      |                      ^~~~~~~

[majetideepak]

Let's initialize the fields in the struct CompressionOptions
example: uint32_t compressionThreshold; must be uint32_t compressionThreshold{0};

[xin-zhang2]

Initialized the fields.
There is no default value for CompressionOptions.format, so I left it empty initialized, which results in format.zlib.windowBits and format.zlib.compressionLevel being initialized to 0.
As for CompressionOptions.compressionThreshold, it is currently used only by DwrfOrcCompression, where its value is configured via orc.compression.threshold, with a default of 256. However, since CompressionOptions is part of the common package, I believe it would be more appropriate to initialize compressionThreshold to 0.
Does the approach seem reasonable?

[majetideepak]

Why change this error message?

[xin-zhang2]

When inputVector is nullptr, inputVector->toString() in the previous message will cause a null pointer dereference.

[majetideepak]

auto vector = restoreVectorFromFile(inputPathsList[i].c_str(), deserializerPool.get());
auto inputVector = std::dynamic_pointer_cast<RowVector>(vector);

use vector->toString() in the null check argument.

[xin-zhang2]

Updated.

[majetideepak]

@xin-zhang2 The experimental CI job that uses GCC 13 needs to be triggered to test this. Can you add a comment somewhere in .github/workflows/experimental.yml to trigger the CI?
We can revert the comment after testing.
Thanks.

[xin-zhang2]

@majetideepak I've added a comment to trigger the CI, but it looks the Experimental Fuzzer Job didn't pick my code.
For example, the error message in the job is

/home/runner/work/velox/velox/velox/velox/vector/tests/VectorMakerTest.cpp:477:65: error: converting to ‘std::optional<std::vector<std::optional<int>, std::allocator<std::optional<int> > > >’ from initializer list would use explicit constructor ‘constexpr std::optional<_Tp>::optional(std::in_place_t, _Args&& ...) [with _Args = {}; typename std::enable_if<__and_v<std::is_constructible<_Tp, _Args ...> >, bool>::type <anonymous> = false; _Tp = std::vector<std::optional<int>, std::allocator<std::optional<int> > >]’
  477 |   VectorPtr expectedVector = maker_.arrayVectorNullable<int32_t>({
      |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
  478 |       {{1, 2}},
      |       ~~~~~~~~~                                                  
  479 |       {{2, 3, 4}},
      |       ~~~~~~~~~~~~                                               
  480 |       {{std::nullopt, 7}},
      |       ~~~~~~~~~~~~~~~~~~~~                                       
  481 |       {{1, 3, 7, 9}},
      |       ~~~~~~~~~~~~~~~                                            
  482 |       {{}},
      |       ~~~~~                                                      
  483 |       {{std::nullopt}},
      |       ~~~~~~~~~~~~~~~~~                                          
  484 |       {{1, 2, std::nullopt}},
      |       ~~~~~~~~~~~~~~~~~~~~~~~                                    
  485 |       {{}},
      |       ~~~~~                                                      
  486 |       std::nullopt,
      |       ~~~~~~~~~~~~~                                              
  487 |       {{1, 2, 3}},
      |       ~~~~~~~~~~~~                                               
  488 |       {{}},
      |       ~~~~~                                                      
  489 |       {{4, 5}},
      |       ~~~~~~~~~                                                  
  490 |   });
      |   ~~          

while I have already made the following change in my PR.

Any idea on this?

[majetideepak]

@xin-zhang2 CI is checking out the main branch. Are you able to test this locally? If yes, we an undo the comment.

[xin-zhang2]

@majetideepak Yes, the build runs successfully on my local ubuntu 24.04 enviroment.
I have reverted the comment commit.

[majetideepak]

@xin-zhang2 thanks for this fix. Meta will import and merge this.