build: Allow options to wget curl cmake during setup #12201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandamideShakyan
requested review from
assignUser and
majetideepak
as code owners
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
changed the title
majetideepak
changed the title
scripts/setup-adapters.sh
Outdated
| @@ -29,6 +29,12 @@ if [[ "$OSTYPE" == darwin* ]]; then | |||
| export INSTALL_PREFIX=${INSTALL_PREFIX:-"$(pwd)/deps-install"} | |||
| fi | |||
|
|
|||
| if [[ "${VERBOSE_LOGGING}" == "true" ]]; then | |||
There was a problem hiding this comment.
Let's define WGET_OPTIONS and let the user specify the options. We can remove VERBOSE_LOGGING var.
There was a problem hiding this comment.
Basically like this
WGET_OPTIONS=${WGET_OPTIONS:-""}
scripts/setup-helper-functions.sh
Outdated
| @@ -20,6 +20,14 @@ DEPENDENCY_DIR=${DEPENDENCY_DIR:-$(pwd)/deps-download} | |||
| OS_CXXFLAGS="" | |||
| NPROC=${BUILD_THREADS:-$(getconf _NPROCESSORS_ONLN)} | |||
|
|
|||
| if [[ "${VERBOSE_LOGGING}" == "true" ]]; then | |||
There was a problem hiding this comment.
Same here. Let's define CURL_OPTIONS and CMAKE_OPTIONS and leave the value to the user to set.
majetideepak
changed the title
anandamideShakyan
force-pushed
the
shakyan-reduce-log
branch
2 times, most recently
from
0d76f64 to
7d4b28d
Compare
majetideepak
approved these changes
Feb 4, 2025
majetideepak
added
the
ready-to-merge
anandamideShakyan
force-pushed
the
shakyan-reduce-log
branch
from
7d4b28d to
3ef084c
Compare
czentgr
approved these changes
Feb 5, 2025
anandamideShakyan
force-pushed
the
shakyan-reduce-log
branch
from
3ef084c to
b184a92
Compare
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current setup scripts generate excessive output, the goal is to reduce the log output by implementing the following changes: