feat: Add new FileFormat::SST to toFileFormat and toString #12137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68463647 |
✅ Deploy Preview for meta-velox canceled.
|
kKPulla
approved these changes
Jan 22, 2025
…ncubator#12137) Summary: A new file format FileFormat::SST was introduced, but it was not added to these methods (toFileFormat and toString). Adding a new case statement to the toFileFormat function to return the FileFormat::SST value when the input string is "sst". The toString function is also updated to include a new case statement to return "sst" when the file format is FileFormat::SST. This will allow users to specify the file format as "sst" when working with Velox. Reviewed By: kKPulla, sdruzkin, harsharastogi Differential Revision: D68463647
emilysun201309
force-pushed
the
export-D68463647
branch
from
362bcee to
98bb2b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68463647 |
|
This pull request has been merged in 5e238f4. |
|
Conbench analyzed the 0 benchmark runs that triggered this notification. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: A new file format FileFormat::SST was introduced, but it was not added to these methods (toFileFormat and toString). Adding a new case statement to the toFileFormat function to return the FileFormat::SST value when the input string is "sst". The toString function is also updated to include a new case statement to return "sst" when the file format is FileFormat::SST. This will allow users to specify the file format as "sst" when working with Velox.
Differential Revision: D68463647