Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GFlags to GlobalConfig change for memoryUseHugepages usage #12133

Closed
wants to merge 1 commit into from
Closed

fix: GFlags to GlobalConfig change for memoryUseHugepages usage #12133

wants to merge 1 commit into from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Jan 21, 2025 •
edited
Loading

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
@majetideepak majetideepak mentioned this pull request Jan 21, 2025
Closed
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 754436f
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/678fa8d8a619c20008ae96bb

@majetideepak majetideepak requested a review from kgpai January 21, 2025 14:07
zhouyuan
zhouyuan approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@majetideepak majetideepak changed the title fix: memoryUseHugepages usage change from gflags fix: Gflags to GlobalConfig change for memoryUseHugepages usage Jan 21, 2025
@majetideepak majetideepak changed the title fix: Gflags to GlobalConfig change for memoryUseHugepages usage fix: GFlags to GlobalConfig change for memoryUseHugepages usage Jan 21, 2025
@facebook-github-bot
Copy link
Contributor

@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

xiaoxmeng
xiaoxmeng approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majetideepak thanks for the fix!

@facebook-github-bot
Copy link
Contributor

@pedroerp merged this pull request in 1a803e1.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 0 benchmark runs that triggered this notification.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

@majetideepak majetideepak deleted the fix-memoryUseHugepages branch January 24, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouyuan zhouyuan zhouyuan approved these changes

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

@kgpai kgpai Awaiting requested review from kgpai

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majetideepak @facebook-github-bot @zhouyuan @xiaoxmeng