Make dwio::common::WriterOptions polymorphic #10380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D59302873 |
Yuhta
reviewed
Jul 3, 2024
|
This pull request was exported from Phabricator. Differential Revision: D59302873 |
pedroerp
force-pushed
the
export-D59302873
branch
from
1d37838 to
a4e6c23
Compare
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Jul 11, 2024
Summary: Pull Request resolved: facebookincubator#10380 Making writer options a virtual class that could be specialized for different file formats to enable Velox users to provided them as part of a query plan. Today, there are a few different ways to pass writer parameters (serdeParams and hive config). They end up being serialized to strings, so can't be used with non-serializable configs. Moreover, file format specific configurations and code end-up in generic parts of the code, like HiveConnector. This will allow us to better organize file format specific options; for now only creating the framework to contain the changes. Reviewed By: kunalkataria, kparichay Differential Revision: D59302873
|
This pull request was exported from Phabricator. Differential Revision: D59302873 |
pedroerp
force-pushed
the
export-D59302873
branch
from
a4e6c23 to
8b4e5a1
Compare
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Jul 12, 2024
Summary: Pull Request resolved: facebookincubator#10380 Making writer options a virtual class that could be specialized for different file formats to enable Velox users to provided them as part of a query plan. Today, there are a few different ways to pass writer parameters (serdeParams and hive config). They end up being serialized to strings, so can't be used with non-serializable configs. Moreover, file format specific configurations and code end-up in generic parts of the code, like HiveConnector. This will allow us to better organize file format specific options; for now only creating the framework to contain the changes. Reviewed By: kunalkataria, kparichay Differential Revision: D59302873
|
This pull request was exported from Phabricator. Differential Revision: D59302873 |
pedroerp
force-pushed
the
export-D59302873
branch
from
8b4e5a1 to
61fdaea
Compare
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Jul 12, 2024
Summary: Pull Request resolved: facebookincubator#10380 Making writer options a virtual class that could be specialized for different file formats to enable Velox users to provided them as part of a query plan. Today, there are a few different ways to pass writer parameters (serdeParams and hive config). They end up being serialized to strings, so can't be used with non-serializable configs. Moreover, file format specific configurations and code end-up in generic parts of the code, like HiveConnector. This will allow us to better organize file format specific options; for now only creating the framework to contain the changes. Reviewed By: kunalkataria, kparichay Differential Revision: D59302873
|
This pull request was exported from Phabricator. Differential Revision: D59302873 |
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Jul 12, 2024
Summary: Pull Request resolved: facebookincubator#10380 Making writer options a virtual class that could be specialized for different file formats to enable Velox users to provided them as part of a query plan. Today, there are a few different ways to pass writer parameters (serdeParams and hive config). They end up being serialized to strings, so can't be used with non-serializable configs. Moreover, file format specific configurations and code end-up in generic parts of the code, like HiveConnector. This will allow us to better organize file format specific options; for now only creating the framework to contain the changes. Reviewed By: kunalkataria, kparichay Differential Revision: D59302873
pedroerp
force-pushed
the
export-D59302873
branch
from
61fdaea to
c572eb5
Compare
pedroerp
added a commit
to pedroerp/velox-1
that referenced
this pull request
Jul 12, 2024
Summary: Pull Request resolved: facebookincubator#10380 Making writer options a virtual class that could be specialized for different file formats to enable Velox users to provided them as part of a query plan. Today, there are a few different ways to pass writer parameters (serdeParams and hive config). They end up being serialized to strings, so can't be used with non-serializable configs. Moreover, file format specific configurations and code end-up in generic parts of the code, like HiveConnector. This will allow us to better organize file format specific options; for now only creating the framework to contain the changes. Reviewed By: kunalkataria, kparichay Differential Revision: D59302873
pedroerp
force-pushed
the
export-D59302873
branch
from
c572eb5 to
d5c1282
Compare
|
This pull request was exported from Phabricator. Differential Revision: D59302873 |
Summary: Pull Request resolved: facebookincubator#10380 Making writer options a virtual class that could be specialized for different file formats to enable Velox users to provided them as part of a query plan. Today, there are a few different ways to pass writer parameters (serdeParams and hive config). They end up being serialized to strings, so can't be used with non-serializable configs. Moreover, file format specific configurations and code end-up in generic parts of the code, like HiveConnector. This will allow us to better organize file format specific options; for now only creating the framework to contain the changes. Reviewed By: kunalkataria, kparichay Differential Revision: D59302873
|
This pull request was exported from Phabricator. Differential Revision: D59302873 |
pedroerp
force-pushed
the
export-D59302873
branch
from
d5c1282 to
559b475
Compare
Yuhta
approved these changes
Jul 15, 2024
|
This pull request has been merged in e0680b9. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
| @@ -262,6 +267,7 @@ class HiveInsertTableHandle : public ConnectorInsertTableHandle { | |||
| const std::shared_ptr<HiveBucketProperty> bucketProperty_; | |||
| const std::optional<common::CompressionKind> compressionKind_; | |||
| const std::unordered_map<std::string, std::string> serdeParameters_; | |||
| const std::shared_ptr<dwio::common::WriterOptions> writerOptions_; | |||
There was a problem hiding this comment.
@pedroerp Hi Pedro, I just bumped into this code.
WriterOptions includes some contextual information (memory pool, spill config, etc.) so I guess it's the reason why it's not included in TableWriteNode's JSON serde, see code.
Do you think this is an issue? Given it's a special case that we include contextual information in query plan node.
There was a problem hiding this comment.
Filed an issue: #12437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Making writer options a virtual class that could be specialized for
different file formats to enable Velox users to provided them as part of a
query plan.
Today, there are a few different ways to pass writer parameters (serdeParams and
hive config). They end up being serialized to strings, so can't be used with
non-serializable configs. Moreover, file format specific configurations and code
end-up in generic parts of the code, like HiveConnector.
This will allow us to better organize file format specific options; for now only
creating the framework to contain the changes.
Differential Revision: D59302873