fix debug build issues

facebookincubator · Mar 4, 2025 · d947235 · d947235
1 parent 15aaf7b
commit d947235
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/velox/functions/prestosql/tests/ArrayCombinationsTest.cpp b/velox/functions/prestosql/tests/ArrayCombinationsTest.cpp
@@ -69,7 +69,8 @@ class ArrayCombinationsTest : public FunctionBaseTest {
         {{
             {{0, 1, std::nullopt, 3}},
         }},
-        {{}},
+        std::make_optional<
+            std::vector<std::optional<std::vector<std::optional<T>>>>>({}),
     });
     testExpr(
         expected, "combinations(C0, C1)", {arrayVector, comboLengthVector});

diff --git a/velox/functions/prestosql/tests/JsonCastTest.cpp b/velox/functions/prestosql/tests/JsonCastTest.cpp
@@ -1270,7 +1270,7 @@ TEST_F(JsonCastTest, toNested) {
   auto arrayExpected = makeNullableNestedArrayVector<StringView>(
       {{{{{"1"_sv, "2"_sv}}, {{"3"_sv}}}},
        {{{{std::nullopt, std::nullopt, "4"_sv}}}},
-       {{{{}}}},
+       {{std::make_optional<std::vector<std::optional<StringView>>>({})}},
        std::make_optional<
            std::vector<std::optional<std::vector<std::optional<StringView>>>>>(
            {})});

diff --git a/velox/vector/fuzzer/VectorFuzzer.h b/velox/vector/fuzzer/VectorFuzzer.h
@@ -145,7 +145,7 @@ class VectorFuzzer {
     fuzzer::DataSpec dataSpec{false, false};
   };
 
-  //
+  // Spurious warnings in GCC 13
   VELOX_SUPPRESS_STRINGOP_OVERFLOW_WARNING
   VectorFuzzer(
       const VectorFuzzer::Options& options,