Skip to content

Commit a837ebd

Browse files
marin-mafacebook-github-bot
authored andcommitted
build(simdjson): Add CMake option to skip utf8 validation (#12165)
Summary: Add VELOX_SIMDJSON_SKIPUTF8VALIDATION CMake option to do this. Discussed in #10639 (comment) Pull Request resolved: #12165 Reviewed By: kgpai Differential Revision: D68754000 Pulled By: xiaoxmeng fbshipit-source-id: 4a5e43dd1c14a17c52d896521af30699b1b541a6
1 parent 9fd0b0f commit a837ebd

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

CMake/resolve_dependency_modules/simdjson.cmake

+4
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,8 @@ FetchContent_Declare(
2929
URL ${VELOX_SIMDJSON_SOURCE_URL}
3030
URL_HASH ${VELOX_SIMDJSON_BUILD_SHA256_CHECKSUM})
3131

32+
if(${VELOX_SIMDJSON_SKIPUTF8VALIDATION})
33+
set(SIMDJSON_SKIPUTF8VALIDATION ON)
34+
endif()
35+
3236
FetchContent_MakeAvailable(simdjson)

CMakeLists.txt

+2
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,8 @@ option(
149149
VELOX_ENABLE_INT64_BUILD_PARTITION_BOUND
150150
"make buildPartitionBounds_ a vector int64 instead of int32 to avoid integer overflow when the hashtable has billions of records"
151151
OFF)
152+
option(VELOX_SIMDJSON_SKIPUTF8VALIDATION
153+
"Skip simdjson utf8 validation in JSON parsing" OFF)
152154

153155
# Explicitly force compilers to generate colored output. Compilers usually do
154156
# this by default if they detect the output is a terminal, but this assumption

0 commit comments

Comments
 (0)