Update to Fable 2.0 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
requested review from
alfonsogarciacaro and
iyegoroff
and removed request for
alfonsogarciacaro
|
@forki Latest version of Fable.React.Native is 2.0.0-alpha-014 should I release it as 2.0.0-alpha-015 or 3.0.0-alpha-001 ? |
|
How about 2.0 proper?
Am Mi., 20. Feb. 2019, 11:11 hat Maxime Mangel <notifications@github.com>
geschrieben:
… @forki <https://github.com/forki> Latest version of Fable.React.Native is
2.0.0-alpha-014 should I release it as 2.0.0-alpha-015 or 3.0.0-alpha-001 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNPapU2koK0_l45W3wgxiWpkkwSZBks5vPR9KgaJpZM4bEvm9>
.
|
|
I was proposing v3 because v2 alpha was for Fable 1.x support. @forki Is it working or do we need an alpha/beta version first? |
|
I don't know yet |
|
@forki I fixed the errors and warnings but I didn't test the project. I don't have a RN app and never created one 😊 Now we need to wait after nuget |
|
thanks! the question now is: how to do the rest of SAFE-Stack/SAFE-Nightwatch#64 - Imean we don't have webpack here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #39
@alfonsogarciacaro any chance you can take a look and release it? I really want to move my RN project to fable 2 - so that I don't need to bug you about bugs in fable 1.x :P
/cc @MangelMaxime