v3: helper for finding instance types #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobajagi
approved these changes
Feb 26, 2025
pierre-emmanuelJ
approved these changes
Feb 26, 2025
tgrondier
deleted the
tgrondier/sc-121845/egoscale-create-helper-for-finding-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code generated by egoscale for FindInstanceType only allows finding by
id. We allow users to specify a string of the form{{InstanceType.Family}}.{{InstanceType.Size}}for instance types; as this is a unique case, rather that complexify the rendering template, we add a small different helper that allows for this.Already exists in
terraform-provider-exoscaleas a helper, which should be removedChecklist
(For exoscale contributors)