Enhancement: Leverage sprintf()

ergebnis · Feb 23, 2025 · 0b8b519 · 0b8b519
1 parent e48f08c
commit 0b8b519
Showing 1 changed file with 11 additions and 27 deletions.
diff --git a/src/Reporter/DefaultReporter.php b/src/Reporter/DefaultReporter.php
@@ -98,36 +98,20 @@ private function list(SlowTestList $slowTestList): array
         $testDurationWidth = \strlen($durationFormatter->format($slowTestWithLongestTestDuration->testDuration()->toDuration()));
         $maximumDurationWidth = \strlen($durationFormatter->format($slowTestWithLongestMaximumDuration->maximumDuration()->toDuration()));
 
-        return \array_map(static function (int $number, SlowTest $slowTest) use ($numberWidth, $durationFormatter, $testDurationWidth, $maximumDurationWidth): string {
-            $formattedNumber = \str_pad(
+        $template = \sprintf(
+            '%%%dd. %%%ds (%%%ds) %%s',
+            $numberWidth,
+            $testDurationWidth,
+            $maximumDurationWidth
+        );
+
+        return \array_map(static function (int $number, SlowTest $slowTest) use ($template, $durationFormatter): string {
+            return \sprintf(
+                $template,
                 (string) $number,
-                $numberWidth,
-                ' ',
-                \STR_PAD_LEFT
-            );
-
-            $formattedDuration = \str_pad(
                 $durationFormatter->format($slowTest->testDuration()->toDuration()),
-                $testDurationWidth,
-                ' ',
-                \STR_PAD_LEFT
-            );
-
-            $formattedMaximumDuration = \str_pad(
                 $durationFormatter->format($slowTest->maximumDuration()->toDuration()),
-                $maximumDurationWidth,
-                ' ',
-                \STR_PAD_LEFT
-            );
-
-            $testDescription = $slowTest->testDescription()->toString();
-
-            return \sprintf(
-                '%s. %s (%s) %s',
-                $formattedNumber,
-                $formattedDuration,
-                $formattedMaximumDuration,
-                $testDescription
+                $slowTest->testDescription()->toString()
             );
         }, \range(1, $slowTestListThatWillBeReported->slowTestCount()->toCount()->toInt()), $slowTestListThatWillBeReported->toArray());
     }