-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate copyright checks (9882 companion) #401
Conversation
I can't get the jobs to start. Is this a permission thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why it doesn't run. Maybe it's not enabled in the repo settings? @Zitchas
Or maybe it's just a security thing since these workflow files are new.
.github/workflows/cd.yml
Outdated
@@ -0,0 +1,38 @@ | |||
name: CD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a CD workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the CD if we don't want to include the .github
files in the release I think?
.github/workflows/cd_release.yml
Outdated
@@ -0,0 +1,32 @@ | |||
name: Release CD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a release CD workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably be folded into the standard CD workflow, I just don't have enough experience and confidence so just copied things over from ES. File names might have to be different, idk.
GitHub just won't run workflows added in a PR if the file doesn't exist in the base branch. |
I think we can have GitHub not include the workflow files in the source code archive with a .gitattributes file.
Which means we don't need to make a continuous release. Actually, we don't need the CD at all if we do that. The CD would just produce an archive with the same contents, but it'd be taking up space and would expire. The source code archives don't count towards a limited storage capacity. |
If that works, that sounds like a great solution. |
Adds the copyright CI checks from ES, though they now run unconditionally since pretty much everything should be editing the copyright file.
The only issue is that now the workflow file would probably be included in the plugin, which seems unfortunate. I think it can be solved by uploading custom artifacts to future releases, but we have to make sure it doesn't break the continuous nor the release builds.
With the included CD stuff we should be able to generate the correct artifacts, but the plugin manifest in https://github.com/endless-sky/endless-sky-plugins will likely have to be updated.