Publish beta branch to appstore connect from Github Actions #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5cdf02.
clangenb
added
A2-technical
clangenb
commented
Jan 5, 2025
| @@ -405,7 +401,7 @@ | |||
| CLANG_WARN_SUSPICIOUS_MOVE = YES; | |||
| CLANG_WARN_UNREACHABLE_CODE = YES; | |||
| CLANG_WARN__DUPLICATE_METHOD_MATCH = YES; | |||
| "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer"; | |||
| "CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "Apple Distribution"; | |||
There was a problem hiding this comment.
This was a crucial change to make xcode use the distribution certificate instead of an inexistent developer certificate.
Comment on lines
+451
to
+452
| PROVISIONING_PROFILE_SPECIFIER = Encointer_AppStore_Deployment.mobileprovision; | ||
| "PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = Encointer_AppStore_Deployment.mobileprovision; |
There was a problem hiding this comment.
We also had to specify the provisioning profile explicitly here in order to help xcode know, which certificate is going to be used.
As we use swift dependencies, we can't use the CLI arguments to pass this option because xcode then tries to use this for our dependencies too and fails. This is a well-known problem.
Comment on lines
+11
to
+12
| <key>org.encointer.wallet</key> | ||
| <string>Encointer_AppStore_Deployment.mobileprovision</string> |
There was a problem hiding this comment.
This needs to match the name in our apple developer portal.
…n there is a commit on beta
This was referenced Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.