Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifications on Android #1700

Merged
merged 7 commits into from
Sep 24, 2024
Merged

Fix notifications on Android #1700

merged 7 commits into from
Sep 24, 2024

Conversation

clangenb
Copy link
Member

@clangenb clangenb commented Sep 24, 2024

Changes:

  • For some reason, we didn't check if notification permissions were given on Android. This is now checked upon startup and the user is prompted to allow notifications.

Fix Scheduled Notifications on Android

  • Fix android manifest to show scheduled permissions and to persist scheduled notifications after a reboot
  • Android > 13 doesn't allow exact scheduling of notifications, which resulted in an error. We simply relaxed our scheduling to inexact, as we are not building a precise alarm app.

@clangenb clangenb added A1-bugfix PR fixes a bug B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes labels Sep 24, 2024
@clangenb clangenb merged commit f12bc4e into master Sep 24, 2024
8 of 10 checks passed
@clangenb clangenb deleted the cl/fix-notifs branch September 24, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1-bugfix PR fixes a bug B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant