-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support system.remark on account manage page #1698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
reviewed
Sep 13, 2024
clangenb
reviewed
Sep 13, 2024
here the entire flow of the first use case: linking a DASH account video: https://github.com/user-attachments/assets/27dda403-5d76-4cdd-a68c-0fa262122172 |
clangenb
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me and I tested it. Two notes:
- it is a bit sad that system remarks doesn't emit an event on the chain, but I guess we can't change that.
- There is no feedback of success if you send a node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A0-ux
PR changes the UX
A2-technical
PR introduces technical changes
B0-low
Does not elevate a release containing this beyond "low priority"
C0-breaksnothing
PR does not introduce any breaking changes
F1-shallow-encointer-domain
Needs a bit of encointer domain knowledge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation:
We've been discussing benefits on other, possibly non-substrate networks. DASH is offering a budget to distribute among reputables similar to the KSM faucet.
What we need to make this happen is an authenticated link to a DASH wallet address. system.remark is the lowest hanging fruit to link an Encointer account to a DAH wacount with public auditability of the distribution process
limit length of note:frame-system pallet has no limit on a remark!notification about tx status success or errorthis is a bug unrelated to this PR