Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support system.remark on account manage page #1698

Merged
merged 11 commits into from
Sep 18, 2024
Merged

support system.remark on account manage page #1698

merged 11 commits into from
Sep 18, 2024

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Sep 12, 2024

motivation:

We've been discussing benefits on other, possibly non-substrate networks. DASH is offering a budget to distribute among reputables similar to the KSM faucet.

What we need to make this happen is an authenticated link to a DASH wallet address. system.remark is the lowest hanging fruit to link an Encointer account to a DAH wacount with public auditability of the distribution process

  • let accountManage page scroll. it overflows on small screens
  • add all translations
  • limit length of note: frame-system pallet has no limit on a remark!
  • notification about tx status success or error this is a bug unrelated to this PR

@brenzi brenzi marked this pull request as ready for review September 14, 2024 16:44
@brenzi brenzi added F1-shallow-encointer-domain Needs a bit of encointer domain knowledge A0-ux PR changes the UX A2-technical PR introduces technical changes B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes labels Sep 14, 2024
@brenzi brenzi requested a review from clangenb September 14, 2024 17:08
@brenzi
Copy link
Member Author

brenzi commented Sep 15, 2024

remark events aren't displayed by js/apps by default. need to scan the blocks:
image

@brenzi
Copy link
Member Author

brenzi commented Sep 15, 2024

here the entire flow of the first use case: linking a DASH account

video: https://github.com/user-attachments/assets/27dda403-5d76-4cdd-a68c-0fa262122172

Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me and I tested it. Two notes:

  • it is a bit sad that system remarks doesn't emit an event on the chain, but I guess we can't change that.
  • There is no feedback of success if you send a node.

@clangenb clangenb merged commit a6e4ba1 into master Sep 18, 2024
7 of 10 checks passed
@clangenb clangenb deleted the ab/remarks branch January 28, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-ux PR changes the UX A2-technical PR introduces technical changes B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes F1-shallow-encointer-domain Needs a bit of encointer domain knowledge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants