Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new proposal types Petition and SpendNative #1697

Merged
merged 13 commits into from
Sep 13, 2024
Merged

new proposal types Petition and SpendNative #1697

merged 13 commits into from
Sep 13, 2024

Conversation

brenzi
Copy link
Member

@brenzi brenzi commented Sep 10, 2024 •
edited
Loading

now supporting new ProposalActions:

  • add translations

notes:

  • many files touched, because rerunning dart run melos run run-polkadart-generate was necessary
  • on Gesell, the migration to democracy storage V1 has purged old proposals (for simplicity) this needed to be handled gracefully in the app
  • UI elegance is limited because there is more info to be displayed about proposals now (Petitions can be up to 256 char)

image

@brenzi brenzi changed the title Ab/proposal spend native new proposal types Petition and SpendNative Sep 10, 2024
@brenzi brenzi requested a review from clangenb September 11, 2024 07:15
@brenzi brenzi marked this pull request as ready for review September 11, 2024 07:16
@brenzi brenzi added A2-technical PR introduces technical changes B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes labels Sep 11, 2024
clangenb
clangenb reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I did:

  • run .flutter/bin/dart run melos format to make the CI happy
  • extracted a helper
  • Ran the app, and it looked good.

I do not have time to do the translations yet.

@brenzi brenzi merged commit 0d032ac into master Sep 13, 2024
9 of 10 checks passed
@clangenb clangenb deleted the ab/proposal-spend-native branch January 28, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb left review comments

Assignees
No one assigned
Labels
A2-technical PR introduces technical changes B0-low Does not elevate a release containing this beyond "low priority" C0-breaksnothing PR does not introduce any breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenzi @clangenb