Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #3776

Merged
merged 14 commits into from
Mar 30, 2024
Merged

Cleanup #3776

merged 14 commits into from
Mar 30, 2024

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Mar 30, 2024

A catchall PR, read the commits.

@Spuds Spuds added this to the 2.0 milestone Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 32.97%. Comparing base (6d9ab46) to head (cfc25d6).
Report is 1 commits behind head on development.

Files Patch % Lines
...s/ElkArte/Attachments/TemporaryAttachmentChunk.php 0.00% 3 Missing ⚠️
sources/ElkArte/Controller/MessageIndex.php 33.33% 2 Missing ⚠️
sources/ElkArte/Controller/Help.php 0.00% 1 Missing ⚠️
sources/ElkArte/Helper/DataValidator.php 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #3776      +/-   ##
=================================================
+ Coverage          32.90%   32.97%   +0.06%     
- Complexity         12925    12931       +6     
=================================================
  Files                288      288              
  Lines              62607    62619      +12     
=================================================
+ Hits               20603    20647      +44     
+ Misses             42004    41972      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spuds Spuds merged commit 080d066 into elkarte:development Mar 30, 2024
10 checks passed
@Spuds Spuds deleted the Cleanup branch March 30, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant