Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wes and tes #255

Merged
merged 6 commits into from
Mar 22, 2024
Merged

refactor: wes and tes #255

merged 6 commits into from
Mar 22, 2024

Conversation

JaeAeich
Copy link
Contributor

@JaeAeich JaeAeich commented Mar 10, 2024

Description

This PR adds type hints and configures the folder structure as discussed for consistency.

fix #251

Checklist

  • My code follows the [contributing guidelines][contributing] of this project.
  • I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have updated the user-facing documentation to describe any new or changed behavior.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have not reduced the existing code coverage.

Comments

THIS BREAKS THE PREVIEW AND DEMO, WILL FIX SOON!!
[contributing]: CONTRIBUTING.md

Copy link

changeset-bot bot commented Mar 10, 2024

⚠️ No Changeset found

Latest commit: 2ba96e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloud-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 6:22pm

@JaeAeich
Copy link
Contributor Author

@SalihuDickson @git-anurag-hub please look into this PR,
Here are the blockers right now:

  • Why do I have to import @elixir-cloud/design in WES and TES individual component for them to work even If I am importing the individual design component that I need?

My guess was because imports are from .../index.js which contains component definition i.e windows.define..., and importing types and individual component class doesn't register the component.

  • Docs are breaking, see the deployment as well, the design components are coming up but not WES and TES.

@JaeAeich JaeAeich added status flag: discuss Needs input from various people status flag: help wanted Extra attention is needed status: blocked Something prevents progress labels Mar 15, 2024
JaeAeich and others added 2 commits March 19, 2024 23:49
Co-authored-by: salihuDickson <salihudickson@gmail.com>
@anuragxxd anuragxxd merged commit cf11b71 into main Mar 22, 2024
10 of 11 checks passed
@anuragxxd anuragxxd deleted the types branch March 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Something prevents progress status flag: discuss Needs input from various people status flag: help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: type hints
3 participants