Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ecc-client-lit-ga4gh-tes): fix lint error #236

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

SalihuDickson
Copy link
Contributor

@SalihuDickson SalihuDickson commented Feb 25, 2024

Description

This PR fixes the lint issue in the lit tes packages

Checklist

  • My code follows the contributing guidelines of this project.
  • I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • I have updated the user-facing documentation to describe any new or changed behavior.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have not reduced the existing code coverage.

Comments

Copy link

changeset-bot bot commented Feb 25, 2024

⚠️ No Changeset found

Latest commit: 763730c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloud-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 11:36am

@JaeAeich
Copy link
Contributor

@SalihuDickson, just for consistency, can we turn 1 to warn instead?

Otherwise it LGTM 🚀

@JaeAeich JaeAeich mentioned this pull request Feb 25, 2024
8 tasks
@SalihuDickson
Copy link
Contributor Author

@SalihuDickson, just for consistency, can we turn 1 to warn instead?

Otherwise it LGTM 🚀

done 👍🏾

Copy link
Contributor

@JaeAeich JaeAeich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the discussion on #233 for more details on approval of this PR.

@JaeAeich JaeAeich merged commit f26ac62 into main Feb 26, 2024
7 checks passed
@JaeAeich JaeAeich deleted the fix/lint-error branch February 26, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants