-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: build scripts #229
build: build scripts #229
Conversation
expand current design package build solution to work for all components
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The react component seems to work 🥳, but there are these couple of issues that I am facing:
Also please update the package-lock.json file. And for some reason on running If anyone wants to test the package as well here is the test design npm package I published 👍 , npm i jaeaeich-design |
Thanks for your detailed review. |
…' into build-scripts
hey @git-anurag-hub, can you please check the vercel logs and help me figure out why the deployment is failing? |
PS: This dom isolation issue will mess up with dark and light mode implementations that an |
Hey @SalihuDickson, here are the logs to debug!
|
@git-anurag-hub @JaeAeich, I've fixed the conflicts, please review. |
LGTM @SalihuDickson 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Description
This PR expands the current utils package design solution to work to make it compatible with all the elixir cloud components provided they meet a short list of requirements
Fixes #(issue)
Checklist
Comments