[MIG v13.0] base_custom_info: fix tests

Author: tfo

base_custom_info/models/custom_info_category.py

@@ -21,13 +21,16 @@ class CustomInfoCategory(models.Model):
     def check_access_rule(self, operation):
         """You access a category if you access at least one property."""
         last_error = None
-        for prop in self.mapped("property_ids"):
-            try:
-                prop.check_access_rule(operation)
-                return
-            except Exception as err:
-                last_error = err
-                pass
+        if not self.env.context.get("check_access_rule_once"):
+            for prop in self.with_context(check_access_rule_once=True).mapped(
+                "property_ids"
+            ):
+                try:
+                    prop.check_access_rule(operation)
+                    return
+                except Exception as err:
+                    last_error = err
+                    pass
         if last_error:
             raise last_error
         return super().check_access_rule(operation)

base_custom_info/models/custom_info_option.py

@@ -31,14 +31,18 @@ class CustomInfoOption(models.Model):
 
     def check_access_rule(self, operation):
         """You access an option if you access at least one property."""
-        last_error = None
-        for prop in self.mapped("property_ids"):
-            try:
-                prop.check_access_rule(operation)
-                return
-            except Exception as err:
-                last_error = err
-                pass
-        if last_error:
-            raise last_error
+        # Avoid to enter in infinite loop
+        if not self.env.context.get("check_access_rule_once"):
+            last_error = None
+            for prop in self.with_context(check_access_rule_once=True).mapped(
+                "property_ids"
+            ):
+                try:
+                    prop.check_access_rule(operation)
+                    return
+                except Exception as err:
+                    last_error = err
+                    pass
+            if last_error:
+                raise last_error
         return super().check_access_rule(operation)

base_custom_info/models/custom_info_template.py

@@ -2,6 +2,8 @@
 # Copyright 2017 Pedro M. Baeza <pedro.baeza@tecnativa.com>
 # License LGPL-3 - See http://www.gnu.org/licenses/lgpl-3.0.html
 
+from psycopg2 import IntegrityError
+
 from odoo import _, api, fields, models
 from odoo.exceptions import ValidationError
 
@@ -47,7 +49,10 @@ def _compute_model(self):
 
     def _inverse_model(self):
         for r in self:
-            r.model_id = self.env["ir.model"].search([("model", "=", r.model)])
+            model = self.env["ir.model"].search([("model", "=", r.model)])
+            if r.model and not model:
+                raise IntegrityError(_("You must set a existing model."))
+            r.model_id = model
 
     @api.model
     def _search_model(self, operator, value):

base_custom_info/models/custom_info_value.py

@@ -37,7 +37,7 @@ class CustomInfoValue(models.Model):
         help="Record that owns this custom value.",
     )
     res_id = fields.Integer(
-        string="Resource ID", required=True, index=True, store=True, ondelete="cascade",
+        string="Resource ID", required=True, index=True, ondelete="cascade",
     )
     property_id = fields.Many2one(
         comodel_name="custom.info.property",

base_custom_info/tests/test_partner.py

@@ -19,6 +19,8 @@ def set_custom_info_for_agrolait(self):
         """Used when you need to use some created custom info."""
         self.agrolait.custom_info_template_id = self.tpl
         self.agrolait._onchange_custom_info_template_id()
+        # need to invalidate cache here: o2m with an integer (res_id) as inverse_name
+        self.agrolait.custom_info_ids.invalidate_cache()
         self.agrolait.get_custom_info_value(
             self.env.ref("base_custom_info.prop_haters")
         ).value_int = 5
@@ -29,6 +31,8 @@ def test_access_granted(self):
         agrolait = self.agrolait.with_user(self.demouser)
         agrolait.custom_info_template_id = self.tpl
         agrolait._onchange_custom_info_template_id()
+        # need to invalidate cache here: o2m with an integer (res_id) as inverse_name
+        self.agrolait.custom_info_ids.invalidate_cache()
         prop_weaknesses = agrolait.env.ref("base_custom_info.prop_weaknesses")
         val_weaknesses = agrolait.get_custom_info_value(prop_weaknesses)
         opt_food = agrolait.env.ref("base_custom_info.opt_food")
@@ -68,6 +72,8 @@ def test_apply_unapply_template(self):
         # Applying a template autofills the values
         self.agrolait.custom_info_template_id = self.tpl
         self.agrolait._onchange_custom_info_template_id()
+        # need to invalidate cache here: o2m with an integer (res_id) as inverse_name
+        self.agrolait.custom_info_ids.invalidate_cache()
         self.assertEqual(len(self.agrolait.custom_info_ids), len(self.tpl.property_ids))
         self.assertEqual(
             self.agrolait.custom_info_ids.mapped("property_id"), self.tpl.property_ids
@@ -76,6 +82,8 @@ def test_apply_unapply_template(self):
         # Unapplying a template empties the values
         self.agrolait.custom_info_template_id = False
         self.agrolait._onchange_custom_info_template_id()
+        # need to invalidate cache here: o2m with an integer (res_id) as inverse_name
+        self.agrolait.custom_info_ids.invalidate_cache()
         self.assertFalse(self.agrolait.custom_info_template_id)
         self.assertFalse(self.agrolait.custom_info_ids)
 
@@ -128,6 +136,8 @@ def test_default_values(self):
         """Default values get applied."""
         self.agrolait.custom_info_template_id = self.tpl
         self.agrolait._onchange_custom_info_template_id()
+        # need to invalidate cache here: o2m with an integer (res_id) as inverse_name
+        self.agrolait.custom_info_ids.invalidate_cache()
         val_weaknesses = self.agrolait.get_custom_info_value(
             self.env.ref("base_custom_info.prop_weaknesses")
         )
@@ -145,6 +155,8 @@ def test_recursive_templates(self):
         self.agrolait.invalidate_cache()
         self.assertIn(tpl_gamer, self.agrolait.all_custom_info_templates())
         self.agrolait._onchange_custom_info_template_id()
+        # need to invalidate cache here: o2m with an integer (res_id) as inverse_name
+        self.agrolait.custom_info_ids.invalidate_cache()
         self.assertTrue(
             tpl_gamer.property_ids < self.agrolait.mapped("custom_info_ids.property_id")
         )

base_custom_info/tests/test_value_conversion.py

@@ -27,6 +27,8 @@ def fill_value(self, prop, value, field="value"):
             value = str(value)
         self.value = self.agrolait.get_custom_info_value(prop)
         self.value[field] = value
+        # need to invalidate cache here: o2m with an integer (res_id) as inverse_name
+        self.agrolait.custom_info_ids.invalidate_cache()
 
     def creation_found(self, value):
         """Ensure you can search what you just created."""