@@ -46,24 +46,21 @@ class CustomInfoValue(models.Model):
4646 readonly = True ,
4747 )
4848 property_sequence = fields .Integer (
49- related = "property_id.sequence" , store = True , index = True , readonly = True ,
49+ related = "property_id.sequence" , store = True , index = True ,
5050 )
5151 category_sequence = fields .Integer (
5252 string = "Category Sequence" ,
5353 related = "property_id.category_id.sequence" ,
5454 store = True ,
55- readonly = True ,
56- )
57- category_id = fields .Many2one (
58- related = "property_id.category_id" , store = True , readonly = True ,
5955 )
60- name = fields .Char (related = "property_id.name" , readonly = True )
61- field_type = fields .Selection (related = "property_id.field_type" , readonly = True ,)
56+ category_id = fields .Many2one (related = "property_id.category_id" , store = True )
57+ name = fields .Char (related = "property_id.name" )
58+ field_type = fields .Selection (related = "property_id.field_type" )
6259 field_name = fields .Char (
6360 compute = "_compute_field_name" ,
6461 help = "Technical name of the field where the value is stored." ,
6562 )
66- required = fields .Boolean (related = "property_id.required" , readonly = True )
63+ required = fields .Boolean (related = "property_id.required" )
6764 value = fields .Char (
6865 compute = "_compute_value" ,
6966 inverse = "_inverse_value" ,
@@ -81,7 +78,6 @@ class CustomInfoValue(models.Model):
8178 domain = "[('property_ids', '=', property_id)]" ,
8279 )
8380
84- @api .multi
8581 def check_access_rule (self , operation ):
8682 """You access a value if you access its owner record."""
8783 if self .env .uid != SUPERUSER_ID :
@@ -113,28 +109,24 @@ def _selection_owner_id(self):
113109 if m .model in self .env and self .env [m .model ]._auto
114110 ]
115111
116- @api .multi
117112 @api .depends ("property_id.field_type" )
118113 def _compute_field_name (self ):
119114 """Get the technical name where the real typed value is stored."""
120115 for s in self :
121116 s .field_name = "value_{!s}" .format (s .property_id .field_type )
122117
123- @api .multi
124118 @api .depends ("res_id" , "model" )
125119 def _compute_owner_id (self ):
126120 """Get the id from the linked record."""
127121 for record in self :
128122 record .owner_id = "{},{}" .format (record .model , record .res_id )
129123
130- @api .multi
131124 def _inverse_owner_id (self ):
132125 """Store the owner according to the model and ID."""
133126 for record in self .filtered ("owner_id" ):
134127 record .model = record .owner_id ._name
135128 record .res_id = record .owner_id .id
136129
137- @api .multi
138130 @api .depends (
139131 "property_id.field_type" ,
140132 "field_name" ,
@@ -154,7 +146,6 @@ def _compute_value(self):
154146 else :
155147 s .value = getattr (s , s .field_name , False )
156148
157- @api .multi
158149 def _inverse_value (self ):
159150 """Write the value correctly converted in the typed field."""
160151 for record in self :
@@ -168,48 +159,47 @@ def _inverse_value(self):
168159 record .value , record .field_type , record .property_id ,
169160 )
170161
171- @api .one
172162 @api .constrains ("property_id" , "value_str" , "value_int" , "value_float" )
173163 def _check_min_max_limits (self ):
174164 """Ensure value falls inside the property's stablished limits."""
175- minimum , maximum = self .property_id .minimum , self .property_id .maximum
176- if minimum <= maximum :
177- value = self [self .field_name ]
178- if not value :
179- # This is a job for :meth:`.~_check_required`
180- return
181- if self .field_type == "str" :
182- number = len (self .value_str )
183- message = _ (
184- "Length for %(prop)s is %(val)s, but it should be "
185- "between %(min)d and %(max)d."
186- )
187- elif self .field_type in {"int" , "float" }:
188- number = value
189- if self .field_type == "int" :
165+ for record in self :
166+ minimum , maximum = record .property_id .minimum , record .property_id .maximum
167+ if minimum <= maximum :
168+ value = record [record .field_name ]
169+ if not value :
170+ # This is a job for :meth:`.~_check_required`
171+ continue
172+ if record .field_type == "str" :
173+ number = len (self .value_str )
190174 message = _ (
191- "Value for %(prop)s is %(val)s, but it should be "
175+ "Length for %(prop)s is %(val)s, but it should be "
192176 "between %(min)d and %(max)d."
193177 )
178+ elif record .field_type in {"int" , "float" }:
179+ number = value
180+ if record .field_type == "int" :
181+ message = _ (
182+ "Value for %(prop)s is %(val)s, but it should be "
183+ "between %(min)d and %(max)d."
184+ )
185+ else :
186+ message = _ (
187+ "Value for %(prop)s is %(val)s, but it should be "
188+ "between %(min)f and %(max)f."
189+ )
194190 else :
195- message = _ (
196- "Value for %(prop)s is %(val)s, but it should be "
197- "between %(min)f and %(max)f."
191+ continue
192+ if not minimum <= number <= maximum :
193+ raise ValidationError (
194+ message
195+ % {
196+ "prop" : record .property_id .display_name ,
197+ "val" : number ,
198+ "min" : minimum ,
199+ "max" : maximum ,
200+ }
198201 )
199- else :
200- return
201- if not minimum <= number <= maximum :
202- raise ValidationError (
203- message
204- % {
205- "prop" : self .property_id .display_name ,
206- "val" : number ,
207- "min" : minimum ,
208- "max" : maximum ,
209- }
210- )
211202
212- @api .multi
213203 @api .onchange ("property_id" )
214204 def _onchange_property_set_default_value (self ):
215205 """Load default value for this property."""
0 commit comments