Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0](backport #42143) feat: turn docs folders into go modules #42647

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 8, 2025

Proposed commit message

go submodules are excluded from the module zip of the parent module

turning docs folder into go modules saves around ~90MB from the module zip

Using beats as a dependency currently adds around ~320MB of data into go cache. Most of it is useless (e.g. docs folder) and is adding unnecessary bloat for downstream users which slows down download, CI, etc.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #42143 done by [Mergify](https://mergify.com).

* feat: turn docs folders into go modules

go submodules are excluded from the module zip of the parent module

turning docs folder into go modules saves around ~90MB from the
module zip

* Update go.mod

* Update go.mod

(cherry picked from commit d43b3b7)
@mergify mergify bot added the backport label Feb 8, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2025
@botelastic
Copy link

botelastic bot commented Feb 8, 2025

This pull request doesn't have a Team:<team> label.

Copy link
Contributor Author

mergify bot commented Feb 10, 2025

This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏

@kruskall
Copy link
Member

@Mergifyio update

Copy link
Contributor Author

mergify bot commented Feb 10, 2025

update

☑️ Nothing to do

  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@kruskall kruskall merged commit 7636d80 into 9.0 Feb 10, 2025
50 checks passed
@kruskall kruskall deleted the mergify/bp/9.0/pr-42143 branch February 10, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport enhancement needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant