Configurable exception throwing on parsing error #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm thinking about this. Leaning towards accepting it. I just have to be careful, because it's a binary breaking change. I'm weighing between uping the version number, or changing it to an overload. I have a general preference for optional params. |
|
I have no problem making it an optional param instead of overload. Let me know your preference and I can get to this within a day or two. |
|
@jbtule I came across this pull request today after long time and changed it to optional param |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of cases where a high numeric value is stored in DBF which overflows the DBF limits. This is then stored as series of
*and the library fails to read the record. In these case we would like to continue reading the DBF and display default value instead. This is also what DBF viewing tools are doing.I made this configurable in
NextRecord()method.