Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore error for "ip neigh flush" because interface has been removed #22

Open
wants to merge 1 commit into
base: 202311.X
Choose a base branch
from

Conversation

peter-yu
Copy link

@peter-yu peter-yu commented Aug 9, 2024

the error message of "ip neigh flush",

$ ip neigh flush dev Ethernet4.10
Cannot find device "Ethernet4.10"

Rarely, the interface has been removed from the kernel and "ip neigh flush" will return error code 1. This will let test_subport.py fail.

fix unit test ip_config_test.py/vlan_test.py fail: mock run_command and update assertion expected result

the error message of "ip neigh flush",

$ ip neigh flush dev Ethernet4.10
Cannot find device "Ethernet4.10"

Rarely, the interface has been removed from the kernel and "ip neigh flush" will return error code 1.
This will let test_subport.py fail.
---

fix unit test ip_config_test.py/vlan_test.py fail:
mock run_command and update assertion expected result
@peter-yu
Copy link
Author

@gord1306 Please help to review

link19430 pushed a commit to link19430/sonic-utilities-ec that referenced this pull request Sep 4, 2024
…decimal (#3153) (#3160)

* Fix the sfputil treats page number as decimal instead of hexadecimal (edge-core#22)

Signed-off-by: Kebo Liu <kebol@nvidia.com>
Co-authored-by: Kebo Liu <kebol@nvidia.com>
bryan1978 pushed a commit that referenced this pull request Jan 17, 2025
…(#3153)

* Fix the sfputil treats page number as decimal instead of hexadecimal (#22)

Fix the sfputil treats page number as decimal instead of hexadecimal

Signed-off-by: Kebo Liu <kebol@nvidia.com>

* remove unreachable code

Signed-off-by: Kebo Liu <kebol@nvidia.com>

---------

Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant