Ignore error for "ip neigh flush" because interface has been removed #22
+27
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the error message of "ip neigh flush", $ ip neigh flush dev Ethernet4.10 Cannot find device "Ethernet4.10" Rarely, the interface has been removed from the kernel and "ip neigh flush" will return error code 1. This will let test_subport.py fail. --- fix unit test ip_config_test.py/vlan_test.py fail: mock run_command and update assertion expected result
|
@gord1306 Please help to review |
link19430
pushed a commit
to link19430/sonic-utilities-ec
that referenced
this pull request
Sep 4, 2024
…decimal (#3153) (#3160) * Fix the sfputil treats page number as decimal instead of hexadecimal (edge-core#22) Signed-off-by: Kebo Liu <kebol@nvidia.com> Co-authored-by: Kebo Liu <kebol@nvidia.com>
bryan1978
pushed a commit
that referenced
this pull request
Jan 17, 2025
…(#3153) * Fix the sfputil treats page number as decimal instead of hexadecimal (#22) Fix the sfputil treats page number as decimal instead of hexadecimal Signed-off-by: Kebo Liu <kebol@nvidia.com> * remove unreachable code Signed-off-by: Kebo Liu <kebol@nvidia.com> --------- Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the error message of "ip neigh flush",
$ ip neigh flush dev Ethernet4.10
Cannot find device "Ethernet4.10"
Rarely, the interface has been removed from the kernel and "ip neigh flush" will return error code 1. This will let test_subport.py fail.
fix unit test ip_config_test.py/vlan_test.py fail: mock run_command and update assertion expected result