Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[reboot] Remove exec from the platform_reboot call when run in kdump capture kernel #1

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

DennisChiuEC
Copy link

What I did

Modify the reboot script not to use 'exec' when performing platform_reboot function call to avoid hang issue during reboot.
Like AS9726-32D/AS9736-64D, it will hang when capture kernel tried to stop sonic platform related service.

@DennisChiuEC
Copy link
Author

@CharlieChenEC @vincentchiang-ec @PJHsieh
Please help to review this PR.
Thanks

@PJHsieh
Copy link

PJHsieh commented Jul 5, 2024

Link to PR sonic-net/sonic-utilities#3396

@PJHsieh PJHsieh self-requested a review July 5, 2024 00:37
@PJHsieh PJHsieh merged commit 891a5a3 into edge-core:202311.X Jul 8, 2024
1 check passed
chiourung pushed a commit to chiourung/sonic-utilities-ec that referenced this pull request Jul 8, 2024
…aidump_by_route_size (#2972)

* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561

Solution and modification:
To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.

(1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host.
(2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format.
(3) Add a new script file: files/scripts/saidump.sh, to do the below steps
  For each ASIC0, such as ASIC0,

  edge-core#1. Save the Redis data.
  sudo sonic-db-cli -n asic$1 SAVE > /dev/null

  edge-core#2. Move dump files to /var/run/redisX/
  docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/"

  edge-core#3. Run rdb command to convert the dump files into JSON files
  sudo python /usr/local/bin/rdb --command json  /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null

  edge-core#4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output.
  docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json"

  edge-core#5. clear
  sudo rm -f /var/run/redis$1/dump.rdb
  sudo rm -f /var/run/redis$1/dump.json

(4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh
* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants