DRAFT: Resolve #8 #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
found-it
reviewed
Feb 7, 2025
| )) | ||
| } else { | ||
| // schristoff(TODO): is it ok? | ||
| return Ok(()) |
There was a problem hiding this comment.
I think this needs to return a warp reply (like above) as OK with a json patch that's empty (eg. []).. I don't see much information on a quick scan here but that's my guess is kubernetes will treat it as a no-op.
found-it
reviewed
Feb 7, 2025
| @@ -1,4 +1,4 @@ | |||
| use anyhow::Result; | |||
| use anyhow::{Ok, Result}; | |||
There was a problem hiding this comment.
Suggested change
| use anyhow::{Ok, Result}; | |
| use anyhow::Result; |
There was a problem hiding this comment.
This should fix the mismatched return type error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.