🐛 GacebookConnect not handle exception correctly

edbizarro · Apr 17, 2019 · 252abd6 · 252abd6
1 parent 0919131
commit 252abd6
Show file tree

Hide file tree

Showing 8 changed files with 6 additions and 9 deletions.
diff --git a/src/Bi/Exceptions/AdobeConnectException.php b/src/Bi/Exceptions/AdobeConnectException.php
diff --git a/src/Bi/Exceptions/FacebookConnectException.php b/src/Bi/Exceptions/FacebookConnectException.php
@@ -2,6 +2,8 @@
 
 namespace Bi\Connect\Exceptions;
 
-class FacebookConnectException extends \Exception
+use Exception;
+
+class FacebookConnectException extends Exception
 {
 }
diff --git a/src/Bi/Exceptions/GoogleAuthException.php b/src/Bi/Exceptions/GoogleAuthException.php
@@ -2,9 +2,6 @@
 
 namespace Bi\Connect\Exceptions;
 
-/**
- * Class GoogleAuthException.
- */
 class GoogleAuthException extends \Exception
 {
 }
diff --git a/src/Bi/Exceptions/GoogleConnectException.php b/src/Bi/Exceptions/GoogleConnectException.php
diff --git a/src/Bi/Exceptions/GoogleCredentialsException.php b/src/Bi/Exceptions/GoogleCredentialsException.php
diff --git a/src/Bi/Exceptions/IntervalException.php b/src/Bi/Exceptions/IntervalException.php
diff --git a/src/Bi/Exceptions/TwitterConnectException.php b/src/Bi/Exceptions/TwitterConnectException.php
diff --git a/tests/FacebookAds/FacebookAdsTest.php b/tests/FacebookAds/FacebookAdsTest.php
@@ -3,7 +3,7 @@
 namespace Edbizarro\BiConnect\Tests\FacebookAds;
 
 use Bi\Connect\Base\Oauth2Connect;
-use Bi\Connect\Exceptions\FacebookConnectException;
+use Bi\Connect\Exceptions\FBConnectException;
 use Bi\Connect\Facebook\FacebookConnect;
 use PHPUnit\Framework\TestCase;
 
@@ -33,18 +33,16 @@ public function it_can_instantiate(): void
     /** @test */
     public function it_cant_get_login_url_without_scope(): void
     {
-        $this->expectException(FacebookConnectException::class);
-
         $this->fbConnect->getLoginUrl();
+        $this->expectException(FBConnectException::class);
     }
 
     /** @test */
     public function it_cant_get_login_url_without_redirect(): void
     {
-        $this->expectException(FacebookConnectException::class);
-
         $this->fbConnect->addScope('analytics');
         $this->fbConnect->getLoginUrl();
+        $this->expectException(FBConnectException::class);
     }
 
     /** @test */