Fix ELK round conversion issues #553
Open
+120
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, "10.83333333333334" from ELK side is considered as "10" on GMF side, instead of "11". Change-Id: I255c421b943636bb9d00cdd3aa9847ea47a185fc
Problem is described here eclipse-elk/elk#1126. There is no simple reproduction use case because the issue was observed in a complex customer diagram. Change-Id: Ib70266ce1039040a19a1d09e2d93283c500c53ea
lredor
force-pushed
the
lre/bug/elk_round_problem
branch
from
a344669 to
acc5328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.