chore: Reduce Kubernetes namespace list request #772
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
/retest |
...ore-api-factory/src/main/java/org/eclipse/che/api/factory/server/scm/GitUserDataFetcher.java
Outdated
Show resolved
Hide resolved
...factory/src/main/java/org/eclipse/che/api/factory/server/scm/PersonalAccessTokenManager.java
Show resolved
Hide resolved
.../org/eclipse/che/api/factory/server/scm/kubernetes/KubernetesPersonalAccessTokenManager.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public Optional<PersonalAccessToken> get(Subject cheUser, String scmServerUrl) | ||
| throws ScmConfigurationPersistenceException, ScmCommunicationException { | ||
| return doGetPersonalAccessTokens(cheUser, null, scmServerUrl).stream().findFirst(); | ||
| } | ||
|
|
There was a problem hiding this comment.
@tolusha is it just cleanup since this method is not used in general?
.../org/eclipse/che/api/factory/server/scm/kubernetes/KubernetesPersonalAccessTokenManager.java
Outdated
Show resolved
Hide resolved
|
|
||
| public interface GitUserDataFetcher { | ||
|
|
||
| /** | ||
| * Retrieve a {@link GitUserData} object from concrete scm provider. If OAuthProvider is not | ||
| * configured, then personal access token should be taken into account. | ||
| * | ||
| * @param namespaceName - the user's namespace name. |
There was a problem hiding this comment.
Please describe what will happen if null is passed.
|
@tolusha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@artaleks9 please, take a look at the failing test |
|
@ibuziuk the The functionality works properly. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, ibuziuk, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.20 :: server_3.x/386: Console, Changes, Git Data |
|
Build 3.20 :: sync-to-downstream_3.x/8839: Console, Changes, Git Data |
|
Build 3.20 :: push-latest-container-to-quay_3.x/5105: Console, Changes, Git Data |
|
Build 3.20 :: get-sources-rhpkg-container-build_3.x/8958: server : 3.x :: Build 66858162 : quay.io/devspaces/server-rhel9:3.20-4 |
|
Build 3.20 :: server_3.x/386: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8839 triggered |
|
Build 3.20 :: update-digests_3.x/8713: Console, Changes, Git Data |
What does this PR do?
chore: Reduce Kubernetes namespace list request
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#23354
How to test this PR?
Deploy Che with server image from the PR, try to open a user dashboard.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.