Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add instructions how to add a manuall PAT secret (#2383 -> 7.50.x) #2409

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

vinokurig
Copy link
Contributor

Add instructions how to add a manuall PAT secret to be able to create factory from private repo if oAuth is not configured.

What does this pull request change?

Chery pick from the main branch, see #2383 (comment)

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Add instructions how to add a manuall PAT secret to be able to create factory from private repo if oAuth is not configured.
@vinokurig vinokurig requested review from rkratky, themr0c and a team as code owners July 27, 2022 09:19
@vinokurig vinokurig requested review from nickboldt and removed request for a team July 27, 2022 09:19
@github-actions
Copy link

github-actions bot commented Jul 27, 2022

🎊 Navigate the preview: https://62e1044d4b5a396c7b93f9ca--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@vinokurig vinokurig merged commit abff8de into 7.50.x Jul 27, 2022
@vinokurig vinokurig deleted the che-21189 branch July 27, 2022 10:12
@che-bot che-bot added this to the 7.50 milestone Jul 27, 2022
@l0rd
Copy link
Contributor

l0rd commented Jul 27, 2022

@vinokurig for my understanding: why we need 2 distinct procedures? I would have rather replaced the existing one (using-a-git-credentials-store_che) with the new one (using-a-git-provider-access-token_che) since the git credential store will be created automatically with the new one hiding that complexity from the user. But more importantly the using-a-git-credentials-store_che has a big problem with repositories that have a devfile in it and I would discourage it at all. If what I am saying makes sense I can create a new PR to remove the old procedure.

@vinokurig
Copy link
Contributor Author

@l0rd I don't think that the procedureusing-a-git-credentials-store_che is redundant because even if it could be created form the PAT secret, user might want to create it separately. However I am OK to have just one approach, so you are welcome with a PR.

@rkratky rkratky changed the title chore: Add instructions how to add a manuall PAT secret (#2383) chore: Add instructions how to add a manuall PAT secret (#2383 -> 7.50.x) Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants