Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default OpenShift console logo #1330

Merged
merged 2 commits into from
Mar 19, 2025
Merged

fix: default OpenShift console logo #1330

merged 2 commits into from
Mar 19, 2025

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Mar 18, 2025

What does this PR do?

Fix default OpenShift console logo.

/static/assets/redhat.svg -> /static/assets/public/imgs/openshift-favicon.png

Screenshot/screencast of this PR

Знімок екрана 2025-03-18 о 18 40 24
Знімок екрана 2025-03-18 о 18 42 21

What issues does this PR fix or reference?

fixes eclipse-che/che#23389

Is it tested? How?

Release Notes

Docs PR

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Mar 18, 2025

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@ibuziuk
Copy link
Member

ibuziuk commented Mar 18, 2025

@SDawley could you please review as well?
@olexii4 will it work in the context of Dev Spaces? if we are all good, please, backport to 7.100.x cc: @dmytro-ndp

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1330

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1330", name: che-dashboard}]}}]"

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.79%. Comparing base (c42b5d3) to head (f8f4e20).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/dashboard-backend/src/routes/api/clusterInfo.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1330      +/-   ##
==========================================
- Coverage   91.95%   91.79%   -0.16%     
==========================================
  Files         501      501              
  Lines       45502    45504       +2     
  Branches     3196     3179      -17     
==========================================
- Hits        41840    41770      -70     
- Misses       3628     3701      +73     
+ Partials       34       33       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olexii4
Copy link
Contributor Author

olexii4 commented Mar 19, 2025

static/assets/public/imgs/openshift-favicon.png

@ibuziuk It will work in the context of Dev Spaces(tested it with DS 3.19).

@dmytro-ndp dmytro-ndp self-requested a review March 19, 2025 13:30
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked PR using Eclipse Che Next and Dev Spaces 3.19.0 with quay.io/eclipse/che-dashboard:pr-1330 dashboard deployed to OCP.

OpenShift icon displayed correctly:

dev-spaces-3 19

eclipse che next

Copy link

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmytro-ndp, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit e2f6ad8 into main Mar 19, 2025
21 of 23 checks passed
@olexii4 olexii4 deleted the CHE-23389 branch March 19, 2025 15:05
@devspacesbuild
Copy link

Build 3.21 :: dashboard_3.x/637: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

olexii4 added a commit that referenced this pull request Mar 19, 2025
* fix: default OpenShift console logo

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.21 :: dashboard_3.x/637: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8958 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

olexii4 added a commit that referenced this pull request Mar 19, 2025
* fix: default OpenShift console logo

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.21 :: get-sources-rhpkg-container-build_3.x/9079: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 67043339 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenShift console image is broken
5 participants