-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default OpenShift console logo #1330
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
@SDawley could you please review as well? |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1330 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1330", name: che-dashboard}]}}]" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
==========================================
- Coverage 91.95% 91.79% -0.16%
==========================================
Files 501 501
Lines 45502 45504 +2
Branches 3196 3179 -17
==========================================
- Hits 41840 41770 -70
- Misses 3628 3701 +73
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@ibuziuk It will work in the context of Dev Spaces(tested it with DS 3.19). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmytro-ndp, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.21 :: dashboard_3.x/637: Console, Changes, Git Data |
Build 3.21 :: sync-to-downstream_3.x/8958: Console, Changes, Git Data |
* fix: default OpenShift console logo Signed-off-by: Oleksii Orel <oorel@redhat.com>
Build 3.21 :: push-latest-container-to-quay_3.x/5119: Console, Changes, Git Data |
Build 3.21 :: get-sources-rhpkg-container-build_3.x/9078: dashboard : 3.x :: Build 67042737 : quay.io/devspaces/dashboard-rhel9:3.21-1 |
Build 3.21 :: update-digests_3.x/8823: Console, Changes, Git Data |
Build 3.21 :: dashboard_3.x/637: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8958 triggered |
Build 3.21 :: operator-bundle_3.x/4595: Console, Changes, Git Data |
Build 3.21 :: sync-to-downstream_3.x/8959: Console, Changes, Git Data |
* fix: default OpenShift console logo Signed-off-by: Oleksii Orel <oorel@redhat.com>
Build 3.21 :: get-sources-rhpkg-container-build_3.x/9079: devspaces-operator-bundle : 3.x :: Failed in 67043339 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Fix default OpenShift console logo.
/static/assets/redhat.svg
->/static/assets/public/imgs/openshift-favicon.png
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23389
Is it tested? How?
Release Notes
Docs PR