Refactors SubmodelRepository/AasRepository Suite #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes redundancy regarding SME Tests * Instead now reuses tests of SubmodelServiceSuite Signed-off-by: Jannik Fried <Jannik.Fried@iese.fraunhofer.de>
Signed-off-by: Jannik Fried <Jannik.Fried@iese.fraunhofer.de>
* Removes redundancy regarding SubmodelReferences Signed-off-by: Jannik Fried <Jannik.Fried@iese.fraunhofer.de>
ahoimariew
reviewed
Feb 21, 2024
| DummyAssetAdministrationShellFactory.addDummySubmodelReference(expected); | ||
| AasService aasService = getAasService(expected); |
There was a problem hiding this comment.
Just for understanding: why have you moved this line down?
There was a problem hiding this comment.
Because otherwise the test would fail, as the SubmodelReference is not added to the AAS.
The SubmodelReference needs to be added before the AAS is registered in the AASService.
I don't know why it worked before, but it didn't after my changes
ahoimariew
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.