-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Action to Build and PyPi Release #843
Conversation
This reverts commit 61a4d26.
Pull Request Test Coverage Report for Build 13388782039Details
💛 - Coveralls |
Hi @xRowe first of all thanks a for investigation your time in the CI issues! I don't understand everything perfectly, maybe you could help me a bit:
And yes, j1939_decoder.py needs the dbc, while I don't know if anybody uses the j1939 decoder. |
5.Update... : Does the release only happen if merged to master or does it also create a release and publish it, if canmatrix.init is updated in other branch?
After that, if release is triggered in the future, and builds is/are successful, then it will automatically upload to PyPI, and the version is equal to the one is set in file |
Hi @xRowe thanks again, sounds good to me, I think understand now, gonna try this for the next release. |
Demo on PyPI:
https://pypi.org/project/testpypi-canmatrix/
In my opinion, the tests file/scripts, should not occur in the release, so I remove it.
But the j1939.dbc, I have no idea to remove it, as it is necessary in j1939_decoder.py
Could you have a look if anything need improve?
Thanks,
Rowe